updating log message with input name #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tabrizian
previously approved these changes
Aug 15, 2023
tanmayv25
previously approved these changes
Aug 16, 2023
|
@nnshah1 Did we check for more locations were we should be including the input name in log message? But should. |
|
I added one more. There is more potential work to make messages more uniform (some give the model name, some do not) - but I think we'd do that separately.. |
Tabrizian
approved these changes
Aug 16, 2023
tanmayv25
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on feedback - adding the input name when logging mismatched data type.
Message is now:
inference input 'INPUT' data type is 'DATATYPE_1', but model 'MODEL' expects 'DATATYPE_2'
Open to other phrasing.