Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenVINO 2023.0.0 #200

Merged
merged 4 commits into from
Jul 7, 2023
Merged

OpenVINO 2023.0.0 #200

merged 4 commits into from
Jul 7, 2023

Conversation

kthui
Copy link
Contributor

@kthui kthui commented Jul 6, 2023

server: triton-inference-server/server#6031
openvino_backend: triton-inference-server/openvino_backend#57

Some notes on the upgrade:

  • The tbb.so library no longer needs to be linked, so it is removed from the build.
  • There are quite a few extra libraries built but not required for CPU acceleration (i.e. PaddlePaddle), so only the required libraries are included to save final image size.

mv l_openvino_toolkit_ubuntu22_2023.0.0.10926.b4452d56304_x86_64/* ${INTEL_OPENVINO_DIR} && \
rm openvino_${ONNXRUNTIME_OPENVINO_VERSION}.tgz && \
(cd ${INTEL_OPENVINO_DIR}/install_dependencies && \
os=ubuntu22.04 ./install_openvino_dependencies.sh -y) && \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the os override was added for initial ubunu22.04 support - would recommend to remove it and ensure openvino os deetection is working correctly (to avoid hiding any issues in the future with os changes)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It is removed: Remove OS override

tools/gen_ort_dockerfile.py Outdated Show resolved Hide resolved
tools/gen_ort_dockerfile.py Outdated Show resolved Hide resolved
tools/gen_ort_dockerfile.py Outdated Show resolved Hide resolved
@nv-kmcgill53 nv-kmcgill53 requested a review from askhade July 6, 2023 21:54
tanmayv25
tanmayv25 previously approved these changes Jul 6, 2023
Copy link
Contributor

@nv-kmcgill53 nv-kmcgill53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want an answer to my last question here. LGTM.

@kthui kthui merged commit 8988c3a into main Jul 7, 2023
@kthui kthui deleted the jacky-ov-2023 branch July 11, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants