Allow uncompressed conda execution enviroments #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyastremsky
requested changes
Jun 29, 2023
jbkyang-nvi
force-pushed
the
kyang-no-conda
branch
from
66c7215 to
4caf969
Compare
This is the documentation in the README |
Missed that. Thanks for clarifying! |
dyastremsky
previously approved these changes
Jun 29, 2023
rmccorm4
reviewed
Jun 29, 2023
jbkyang-nvi
force-pushed
the
kyang-no-conda
branch
from
05ff2dd to
03c0701
Compare
rmccorm4
previously approved these changes
Jun 30, 2023
dyastremsky
previously approved these changes
Jun 30, 2023
Tabrizian
requested changes
Jul 3, 2023
There was a problem hiding this comment.
@jbkyang-nvi Have you verified that the environment wouldn't be deleted after the server terminates? By default Python backend would delete the environments once it terminates.
jbkyang-nvi
force-pushed
the
kyang-no-conda
branch
from
8a33bcb to
d117636
Compare
jbkyang-nvi
force-pushed
the
kyang-no-conda
branch
3 times, most recently
from
d998810 to
4398718
Compare
jbkyang-nvi
force-pushed
the
kyang-no-conda
branch
from
4398718 to
ade2d19
Compare
Tabrizian
reviewed
Jul 7, 2023
Tabrizian
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow uncompressed conda execution environments and add documentation for custom execution environments.
Test: triton-inference-server/server#6005