Copy HPCX paths for CPU images #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tabrizian
reviewed
Jun 8, 2023
Comment on lines
+193
to
+213
| if(NOT TRITON_ENABLE_GPU) | ||
| set(HPCX_LIBS | ||
| "libucc.so.1" | ||
| "libucm.so.0" | ||
| "libucp.so.0" | ||
| "libucs.so.0" | ||
| "libuct.so.0" | ||
| ) | ||
| add_custom_command( | ||
| OUTPUT | ||
| ${HPCX_LIBS} | ||
| COMMAND docker pull ${TRITON_PYTORCH_DOCKER_IMAGE} | ||
| COMMAND docker rm pytorch_backend_hpcxlib || echo "error ignored..." || true | ||
| COMMAND docker create --name pytorch_backend_hpcxlib ${TRITON_PYTORCH_DOCKER_IMAGE} | ||
| COMMAND docker cp -L pytorch_backend_hpcxlib:/opt/hpcx/ucc/lib/libucc.so.1 libucc.so.1 | ||
| COMMAND docker cp -L pytorch_backend_hpcxlib:/opt/hpcx/ucx/lib/libucm.so.0 libucm.so.0 | ||
| COMMAND docker cp -L pytorch_backend_hpcxlib:/opt/hpcx/ucx/lib/libucp.so.0 libucp.so.0 | ||
| COMMAND docker cp -L pytorch_backend_hpcxlib:/opt/hpcx/ucx/lib/libucs.so.0 libucs.so.0 | ||
| COMMAND docker cp -L pytorch_backend_hpcxlib:/opt/hpcx/ucx/lib/libuct.so.0 libuct.so.0 | ||
| COMMAND docker rm pytorch_backend_hpcxlib | ||
| VERBATIM |
There was a problem hiding this comment.
Instead of modifying cmake can we copy over the whole /opt/hpcx/ucc/ and /opt/hpcx/ucx in the build.py?
There was a problem hiding this comment.
Sure, I will try this approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy HPCX paths from the PyTorch container for CPU-only builds, so that it has the expected version of HPCX dependencies for libtorch.so.
Server: triton-inference-server/server#5922