-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding RestrictedFeatures Support to the Python Frontend Bindings #7775
base: main
Are you sure you want to change the base?
Changes from 56 commits
86584d7
8f09b68
d418823
c5dfb0b
9020e4a
b739339
41f394d
36acf25
e4fe9f9
151acf4
48c3a59
a2f24de
eefe8e6
6368acb
8b962f8
91b3b68
dea9b00
291d0cc
ba42dbe
a4f0540
9c992bc
231e85a
ee66d9c
f29c14f
5671156
ed74aa9
f21da8f
1027984
06254c8
3703c04
770dd79
b46b124
a490275
24bbbc1
101f409
b5853a0
30375db
3be2556
c2643ff
0f82ca2
c415fdb
dae9159
17c2831
abf7407
4953905
714fdec
81afad1
1dd4031
dfd1b74
83d98c4
2176034
2231663
aa28071
b699a8c
fbaf864
fd33d99
d2f0f9b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -51,7 +51,14 @@ fi | |
|
||
|
||
FRONTEND_TEST_LOG="./python_kserve.log" | ||
python -m pytest --junitxml=test_kserve.xml test_kserve.py > $FRONTEND_TEST_LOG 2>&1 | ||
# TODO: [DLIS-7735] Run tritonclient.grpc as separate process | ||
# Currently, running tritonclient.grpc with tritonserver in the same process, | ||
# it will non-deterministically abort/crash without being able to be caught by pytest. | ||
# This is because fork() is called by tritonserver on model load, | ||
# which attempts to fork the imported libraries and their internal states, | ||
# and cygrpc (dependency of tritonclient.grpc) does not officially support fork(). | ||
# Reference: https://github.com/grpc/grpc/blob/master/doc/fork_support.md | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Couldn't you just set env var as mentioned here so that the tests work with fork? https://github.com/grpc/grpc/blob/master/doc/fork_support.md#current-status There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Attempted to set and run test suite locally, but the test cases were still failing. |
||
python -m pytest --junitxml=test_kserve.xml test_kserve.py -k "not KServeGrpc" > $FRONTEND_TEST_LOG 2>&1 | ||
if [ $? -ne 0 ]; then | ||
cat $FRONTEND_TEST_LOG | ||
echo -e "\n***\n*** Test Failed\n***" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the claim is that we're calling
fork()
during model load, aren't we instantiating grpc (client) after thefork()
if server/service have already started up?Can you ever reproduce this by only running a single test case repeatedly? If not, it's possible it's coming from the threshold between test cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From, my understanding it is an internal state set upon import: