Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fix Windows CI Errors #7837

Merged
merged 4 commits into from
Dec 17, 2024
Merged

ci: Fix Windows CI Errors #7837

merged 4 commits into from
Dec 17, 2024

Conversation

fpetrini15
Copy link
Contributor

@fpetrini15 fpetrini15 commented Nov 27, 2024 •
edited
Loading

What does the PR do?

Fixes accumulated errors in Windows CI.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

CI Pipeline ID:

20833929

@fpetrini15 fpetrini15 added the PR: ci Changes to our CI configuration files and scripts label Nov 27, 2024
@fpetrini15 fpetrini15 force-pushed the fpetrini-fix-win-tests branch from a32aa0f to e4c039d Compare November 27, 2024 17:38
rmccorm4
rmccorm4 reviewed Nov 27, 2024
View reviewed changes
qa/common/infer_util.py Outdated Show resolved Hide resolved
rmccorm4
rmccorm4 reviewed Nov 27, 2024
View reviewed changes
qa/L0_trt_plugin/test.sh Outdated Show resolved Hide resolved
fpetrini15 and others added 4 commits December 9, 2024 13:58
@fpetrini15
Fixes
dbe8beb
@fpetrini15
Use kill_server
e187538
@fpetrini15 @rmccorm4
Commit suggestion
8141dd3 
Co-authored-by: Ryan McCormick <rmccormick@nvidia.com>
@fpetrini15
Review comments
ccc9651
@fpetrini15 fpetrini15 force-pushed the fpetrini-fix-win-tests branch from c43d0cb to ccc9651 Compare December 9, 2024 21:59
@fpetrini15 fpetrini15 requested a review from rmccorm4 December 9, 2024 23:49
rmccorm4
rmccorm4 approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 MTTLG

@fpetrini15 fpetrini15 merged commit 838966a into main Dec 17, 2024
3 checks passed
@fpetrini15 fpetrini15 deleted the fpetrini-fix-win-tests branch December 17, 2024 00:05
@fpetrini15 fpetrini15 restored the fpetrini-fix-win-tests branch December 17, 2024 00:11
@fpetrini15 fpetrini15 mentioned this pull request Dec 17, 2024
Merged
@fpetrini15 fpetrini15 deleted the fpetrini-fix-win-tests branch December 17, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmccorm4 rmccorm4 rmccorm4 approved these changes

@mc-nv mc-nv Awaiting requested review from mc-nv

@nv-anants nv-anants Awaiting requested review from nv-anants

Assignees
No one assigned
Labels
PR: ci Changes to our CI configuration files and scripts
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fpetrini15 @rmccorm4 @mc-nv