Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
We were hiting the case, when
cudaMemcpy
was copying output to GPU in an async way without proper synchronization. Thus, when during the test client side was reading output result from cuda SHM, there were no guarantees that server side finished the copy. As a result, test failures.Resolution: use cudaMemcpyAsync + sync on stream.
Documentation reference: https://docs.nvidia.com/cuda/cuda-c-programming-guide/#concurrent-execution-between-host-and-device
Checklist
<commit_type>: <Title>
Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
Where should the reviewer start?
Test plan:
21063313 - relevant test: L0_sequence_batcher_cudashm--base
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)