Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Dockerfiles generated by build.py for RHEL require base image specification #7900

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

saturley-hall
Copy link

@saturley-hall saturley-hall commented Dec 20, 2024

What does the PR do?

Images built for RHEL which did not specify a base image defaulted to Ubuntu 24.04 which caused error during the docker build stage as the yum package manager was unavailable. This change causes build.py to error out with a message should the RHEL target be specified without a base image also being specified.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

  • CI Pipeline ID:

Caveats:

Specification of a RHEL base image does not guarantee that the container will build as there are internal dependencies that may be missing.

@saturley-hall saturley-hall added the PR: build Changes that affect the build system or external dependencies label Dec 20, 2024
@saturley-hall saturley-hall changed the title build: Dockerfiles generated for RHEL specific base img errors build.py build: Dockerfiles generated by build.py for RHEL require base image specification Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: build Changes that affect the build system or external dependencies
Development

Successfully merging this pull request may close these issues.

1 participant