Skip to content

Commit

Permalink
Fix gtest_discover_tests timeout argument (#5149)
Browse files Browse the repository at this point in the history
`gtest_discover_tests` runs the built unittest executable to create a
distinct CMake target for every individual unittest in each executable.
However, this was previously noted to time out on MacOS frequently
(because MacOS scans newly built executables for viruses, or
something...) but the timeout argument was incorrectly specified.
  • Loading branch information
Mogball authored Nov 14, 2024
1 parent a9dda9e commit 38f6a6d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cmake/AddTritonUnitTest.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,5 @@ function(add_triton_ut)
# Without the TEST_DISCOVERY_TIMEOUT, the tests randomly time out on my mac
# laptop. I think the issue may be that the very first time you run a program
# it's a bit slow.
gtest_discover_tests(${__NAME} PROPERTIES TEST_DISCOVERY_TIMEOUT 60)
gtest_discover_tests(${__NAME} DISCOVERY_TIMEOUT 60)
endfunction()

0 comments on commit 38f6a6d

Please sign in to comment.