Skip to content

Commit

Permalink
[AMD] Disable overflow check while fixing issues (#5078)
Browse files Browse the repository at this point in the history
These two tests causes significant CI runtime increase (10x)
so disabling them to unblock while figuring out issues.
  • Loading branch information
antiagainst authored Nov 5, 2024
1 parent 053ced9 commit 627ebbb
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions python/test/unit/language/test_core.py
Original file line number Diff line number Diff line change
Expand Up @@ -2547,6 +2547,8 @@ def kernel(X, Y, N, BLOCK_M: tl.constexpr, BLOCK_N: tl.constexpr, NUM_PID_N: tl.
@pytest.mark.parametrize("axis", [0, 1])
@pytest.mark.parametrize("add_overflow_check", [False, True])
def test_scan_layouts(M, N, src_layout, axis, add_overflow_check, device, tmp_path: pathlib.Path):
if add_overflow_check is True and is_hip():
pytest.skip("overflow check disabled on HIP while fixing issues")

overflow_check = """
%17 = arith.extsi %arg2 : i32 to i64
Expand Down Expand Up @@ -2650,6 +2652,8 @@ def test_reduce_layouts(M, N, src_layout, axis, epilogue_kind, dtype_str, add_ov
pytest.skip("Skipping because tensor shape is smaller than M(f)maLayout instr_shape")
if is_hip() and isinstance(src_layout, MfmaLayout) and ((M, N) == (128, 128)):
pytest.skip("Skipping test because it runs out of shared memory")
if add_overflow_check is True and is_hip():
pytest.skip("overflow check disabled on HIP while fixing issues")
if reduce_op == "sum" and dtype_str == "float16" and M * N > 1024:
pytest.skip("Skipping sum reduction on float16 due to accuracy issues")

Expand Down

0 comments on commit 627ebbb

Please sign in to comment.