require cmake 3.18, make policy conditional #1303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malfet
approved these changes
Mar 8, 2023
There was a problem hiding this comment.
Thank you for proposing the change, do you mind including reference to https://cmake.org/cmake/help/v3.0/manual/cmake-policies.7.html documentation in PR description
malfet
pushed a commit
that referenced
this pull request
Mar 9, 2023
According to https://cmake.org/cmake/help/v3.0/manual/cmake-policies.7.html, just setting policy shouldn't require changing minimum required CMake version (moreover, setting minimum cmake version by default sets all new policies to True) cc @malfet (cherry picked from commit 9e6346e)
rkindi
pushed a commit
to rkindi/triton
that referenced
this pull request
Apr 6, 2023
According to https://cmake.org/cmake/help/v3.0/manual/cmake-policies.7.html, just setting policy shouldn't require changing minimum required CMake version (moreover, setting minimum cmake version by default sets all new policies to True) cc @malfet
pingzhuu
pushed a commit
to siliconflow/triton
that referenced
this pull request
Apr 2, 2024
According to https://cmake.org/cmake/help/v3.0/manual/cmake-policies.7.html, just setting policy shouldn't require changing minimum required CMake version (moreover, setting minimum cmake version by default sets all new policies to True) cc @malfet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://cmake.org/cmake/help/v3.0/manual/cmake-policies.7.html, just setting policy shouldn't require changing minimum required CMake version (moreover, setting minimum cmake version by default sets all new policies to True)
cc @malfet