set warp synchronous true for reducing RankedTensorType without layout #4663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hronous getSrcLayout may return null for RankedTensorType without layout. For these reduces, we should process them in one warp
ThomasRaoux
reviewed
Sep 6, 2024
| @@ -168,6 +168,8 @@ unsigned ReduceOpHelper::getThreadsReductionAxis() { | |||
|
|
|||
| bool ReduceOpHelper::isWarpSynchronous() { | |||
| auto srcLayout = getSrcLayout(); | |||
| if (!srcLayout) | |||
There was a problem hiding this comment.
why would there be no layout on the source? This hekper is meant to be used for lowering of trgir to llvm so the tensor should have a layout
There was a problem hiding this comment.
encoding is not necessary for RankedTensorType in MLIR. For reducing vector to scalar cases, I meet these cases without layout. Do you mean every tensor in ttgir must have a layout?
There was a problem hiding this comment.
yes in ttgir every tensor must have a layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not making a trivial change, such as fixing a typo in a comment.
I have written a PR description following these
rules.
I have run
pre-commit run --from-ref origin/main --to-ref HEAD.Select one of the following.
/testforlittests/unittestfor C++ tests/python/testfor end-to-end testsIt's just a change about ReduceOpHelper, not in a lower pipeline.