Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] enable win32 llvm build #4941

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Conversation

wkpark
Copy link
Contributor

@wkpark wkpark commented Oct 17, 2024

from #2757

  • fix deprecation warning
  • use bash shell to fix az storage ... console error.
  • -DLLVM_ENABLE_DIA_SDK=OFF added to fix DIA_SDK dependency - "ninja: error: 'C:/Program Files/Microsoft Visual Studio/2022/Enterprise/DIA SDK/lib/amd64/diaguids.lib', needed by 'D:/src/triton/python/build/lib.win-amd64-cpython-310/triton/_C/libtriton.pyd', missing and no known rule to make it".

the latest windows llvm build is available at https://github.com/wkpark/triton/releases/tag/llvm-82f5acfb-windows

It would be nice to have default llvm;mlir compiler on the official trion build system for someone who trying to develop solve some windows related issue even if windows is not officially supported.

p.s.: and I'd like to thank all triton developers for their hard work!

@wkpark wkpark requested a review from ptillet as a code owner October 17, 2024 13:15
@ThomasRaoux
Copy link
Collaborator

can you first send it to llvm-dev then create another PR from that branch to get the llvm build to kick off

@wkpark
Copy link
Contributor Author

wkpark commented Oct 17, 2024

can you first send it to llvm-dev then create another PR from that branch to get the llvm build to kick off

sorry to ask, where can I find the llvm-dev brach? you mean llvm-head?

@wkpark wkpark changed the base branch from main to llvm-head October 17, 2024 19:59
@ThomasRaoux
Copy link
Collaborator

can you first send it to llvm-dev then create another PR from that branch to get the llvm build to kick off

sorry to ask, where can I find the llvm-dev brach? you mean llvm-head?

yes sorry I meant llvm-head

 * build "mlir;llvm"
 * disable LLVM_ENABLE_DIA_SDK
 * use bash shell to fix error
@ThomasRaoux ThomasRaoux merged commit 4f6079e into triton-lang:llvm-head Oct 18, 2024
chsigg pushed a commit to openxla/triton that referenced this pull request Nov 4, 2024
from triton-lang#2757

 * fix deprecation warning
 * use bash shell to fix `az storage ...` console  error.
* `-DLLVM_ENABLE_DIA_SDK=OFF` added to fix `DIA_SDK` dependency -
`"ninja: error: 'C:/Program Files/Microsoft Visual
Studio/2022/Enterprise/DIA SDK/lib/amd64/diaguids.lib', needed by
'D:/src/triton/python/build/lib.win-amd64-cpython-310/triton/_C/libtriton.pyd',
missing and no known rule to make it"`.

the latest windows llvm build is available at
https://github.com/wkpark/triton/releases/tag/llvm-82f5acfb-windows

It would be nice to have default llvm;mlir compiler on the official
trion build system for someone who trying to develop solve some windows
related issue even if windows is not officially supported.

p.s.: and I'd like to thank all triton developers for their hard work!
chsigg pushed a commit that referenced this pull request Nov 5, 2024
from #2757

 * fix deprecation warning
 * use bash shell to fix `az storage ...` console  error.
* `-DLLVM_ENABLE_DIA_SDK=OFF` added to fix `DIA_SDK` dependency -
`"ninja: error: 'C:/Program Files/Microsoft Visual
Studio/2022/Enterprise/DIA SDK/lib/amd64/diaguids.lib', needed by
'D:/src/triton/python/build/lib.win-amd64-cpython-310/triton/_C/libtriton.pyd',
missing and no known rule to make it"`.

the latest windows llvm build is available at
https://github.com/wkpark/triton/releases/tag/llvm-82f5acfb-windows

It would be nice to have default llvm;mlir compiler on the official
trion build system for someone who trying to develop solve some windows
related issue even if windows is not officially supported.

p.s.: and I'd like to thank all triton developers for their hard work!
chsigg pushed a commit that referenced this pull request Nov 7, 2024
from #2757

 * fix deprecation warning
 * use bash shell to fix `az storage ...` console  error.
* `-DLLVM_ENABLE_DIA_SDK=OFF` added to fix `DIA_SDK` dependency -
`"ninja: error: 'C:/Program Files/Microsoft Visual
Studio/2022/Enterprise/DIA SDK/lib/amd64/diaguids.lib', needed by
'D:/src/triton/python/build/lib.win-amd64-cpython-310/triton/_C/libtriton.pyd',
missing and no known rule to make it"`.

the latest windows llvm build is available at
https://github.com/wkpark/triton/releases/tag/llvm-82f5acfb-windows

It would be nice to have default llvm;mlir compiler on the official
trion build system for someone who trying to develop solve some windows
related issue even if windows is not officially supported.

p.s.: and I'd like to thank all triton developers for their hard work!
vwbaker pushed a commit to openxla/triton that referenced this pull request Nov 11, 2024
from triton-lang#2757

 * fix deprecation warning
 * use bash shell to fix `az storage ...` console  error.
* `-DLLVM_ENABLE_DIA_SDK=OFF` added to fix `DIA_SDK` dependency -
`"ninja: error: 'C:/Program Files/Microsoft Visual
Studio/2022/Enterprise/DIA SDK/lib/amd64/diaguids.lib', needed by
'D:/src/triton/python/build/lib.win-amd64-cpython-310/triton/_C/libtriton.pyd',
missing and no known rule to make it"`.

the latest windows llvm build is available at
https://github.com/wkpark/triton/releases/tag/llvm-82f5acfb-windows

It would be nice to have default llvm;mlir compiler on the official
trion build system for someone who trying to develop solve some windows
related issue even if windows is not officially supported.

p.s.: and I'd like to thank all triton developers for their hard work!
gflegar pushed a commit to openxla/triton that referenced this pull request Dec 4, 2024
from triton-lang#2757

 * fix deprecation warning
 * use bash shell to fix `az storage ...` console  error.
* `-DLLVM_ENABLE_DIA_SDK=OFF` added to fix `DIA_SDK` dependency -
`"ninja: error: 'C:/Program Files/Microsoft Visual
Studio/2022/Enterprise/DIA SDK/lib/amd64/diaguids.lib', needed by
'D:/src/triton/python/build/lib.win-amd64-cpython-310/triton/_C/libtriton.pyd',
missing and no known rule to make it"`.

the latest windows llvm build is available at
https://github.com/wkpark/triton/releases/tag/llvm-82f5acfb-windows

It would be nice to have default llvm;mlir compiler on the official
trion build system for someone who trying to develop solve some windows
related issue even if windows is not officially supported.

p.s.: and I'd like to thank all triton developers for their hard work!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants