Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUNTIME] Add callback functions for external tools #738

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

Jokeren
Copy link
Contributor

@Jokeren Jokeren commented Oct 4, 2022

No description provided.

@Jokeren Jokeren force-pushed the keren/add-callback branch from 62680e1 to e1d3e2a Compare October 5, 2022 20:22
@Jokeren Jokeren marked this pull request as ready for review October 5, 2022 20:23
@Jokeren Jokeren changed the title Add callback functions for external tools [RUNTIME] Add callback functions for external tools Oct 5, 2022
@Jokeren
Copy link
Contributor Author

Jokeren commented Oct 5, 2022

grid dims, block dims, and stream can be reported with CUPTI. So we can avoid passing these arguments to the tool.

@ptillet
Copy link
Collaborator

ptillet commented Oct 5, 2022

LGTM!

@ptillet ptillet merged commit 11345e9 into master Oct 5, 2022
@ptillet ptillet deleted the keren/add-callback branch October 5, 2022 21:46
pingzhuu pushed a commit to siliconflow/triton that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants