Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKEND] Add isRow attribute for DotOp tensors whose parent is mmav1 #970

Merged
merged 10 commits into from
Dec 12, 2022

Conversation

ptillet
Copy link
Collaborator

@ptillet ptillet commented Dec 9, 2022

No description provided.

Copy link
Collaborator

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -212,6 +209,8 @@ def test_gemm(SIZE_M, SIZE_N, SIZE_K, NUM_WARPS, BLOCK_SIZE_M, BLOCK_SIZE_N, BLO
b = torch.randn((SIZE_K, SIZE_N), device='cuda', dtype=torch.float16)

c = torch.empty((SIZE_M, SIZE_N), device=a.device, dtype=torch.float32)
# matmul_kernel = triton.compile("./test.ttgir", num_warps=1)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this?

@ptillet ptillet merged commit 52accd4 into triton-mlir Dec 12, 2022
@ptillet ptillet deleted the phil/mma-v1-is-row branch December 12, 2022 03:01
ZzEeKkAa pushed a commit to ZzEeKkAa/triton that referenced this pull request Aug 5, 2024
Signed-off-by: Whitney Tsang <whitney.tsang@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants