New built-in OAuth Access Token Store: iCloud Key-Value Storage #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 5, 2016 23:32
…ents for an OAuth Access Token Store.
…age. If in DEBUG configuration a proper exception is raised in case the synchronisation fails.
… iCloud Key-Value based access token store.
|
|
||
| store.setDictionary(accessTokenDictionaryRepresentation, forKey: service) | ||
| } | ||
|
|
There was a problem hiding this comment.
What if the optional accessToken is nil?
|
Hi and thanks for your contribution! I had a look and I think this is definitely the right way to go! Regarding testing I would try the following: Regarding the |
ugoArangino
force-pushed
the
master
branch
3 times, most recently
from
4c3875f to
5551b42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added a new OAuth Access Token Store base on iCloud Key-Value Storage.
Why
I wanted to have the opportunity to store access token information in a shared container accessible from other devices that do not have capabilities to support the OAuth 2 authentication process (like tvOS). By using this new built in store, the user can rely on the iCloud Key-Value Storage, connected to his personal iCloud account, to share authentication information retreived from other devices.
Notes
I'm not sure how to write tests for this feature. The new class I created his heavily coupled with a valid iCloud Key-Value Storage. Any idea?
It would be nice to improve the
OAuthAccessTokenStoreprotocol with a proper callback method that notifies when a new access token has been set. Currently, if new information have been sent from another device, the user has to manually query the iCloud Key-Value Store again to retrieve new information.