Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spoolfile message formatting #248

Merged
merged 7 commits into from
Apr 16, 2019
Merged

Fix spoolfile message formatting #248

merged 7 commits into from
Apr 16, 2019

Conversation

arnecls
Copy link
Contributor

@arnecls arnecls commented Apr 15, 2019

The purpose of this pull request

Since 0.5.0, the spooling format is broken, as messages are written to the spool file in plaintext and not as base64 encoded protobuf.

Config to verify

"Generator":
    Type: "consumer.Profiler"
    Streams: "profile"
    Runs: 1000000
    Batches: 1000
    Characters: "abcdefghijklmnopqrstuvwxyz .,!;:-_"
    Message: "%256s"

"SocketOut":
    Type: "producer.Socket"
    Streams: "profile"
    ChannelTimeoutMs: 10
    Address: "127.0.0.1:5880"
    Modulators: 
        - "format.Runlength"
    ConnectionBufferSizeKB: 128
    FallbackStream: "spooling"
    Batch:
        TimeoutSec: 1
    Acknowledge: "OK"

"Spooler":
    Type: "producer.Spooling"
    Streams: "spooling"
    Path: "test"
    MaxFileSizeMB: 512```

Checklist

  • make test executed successfully
  • integration test provided

@arnecls arnecls added the bug label Apr 15, 2019
@arnecls arnecls added this to the v0.6.0 milestone Apr 15, 2019
@arnecls arnecls requested a review from msiebeneicher April 15, 2019 14:47
@arnecls arnecls self-assigned this Apr 15, 2019
Copy link
Contributor

@msiebeneicher msiebeneicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT - Resolve blocking spooler during shutdown:

[2019-04-15 17:42:07 CEST] ERROR Timeout during onPrepareStop. PluginID=bi-spooler PluginType=producer.Spooling
[2019-04-15 17:42:07 CEST] DEBUG Executing stop command PluginID=bi-spooler PluginType=producer.Spooling
[2019-04-15 17:42:12 CEST] ERROR At least one producer found to be blocking.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 71.642% when pulling 2f190cf on fix-spool-format into 2081050 on master.

@coveralls
Copy link

coveralls commented Apr 16, 2019

Coverage Status

Coverage decreased (-0.05%) to 71.711% when pulling c977963 on fix-spool-format into 2081050 on master.

@arnecls arnecls merged commit 8d37739 into master Apr 16, 2019
@arnecls arnecls deleted the fix-spool-format branch April 16, 2019 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants