Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default value of libsc preference #75

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

JoshuaLampert
Copy link
Member

As discussed in #73. I also added a short section in the docs about troubleshoots for the preferences in P4est.jl.

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #75 (aedd9b3) into main (8df7e36) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #75   +/-   ##
=======================================
  Coverage   15.42%   15.42%           
=======================================
  Files           3        3           
  Lines        1511     1511           
=======================================
  Hits          233      233           
  Misses       1278     1278           
Flag Coverage Δ
unittests 15.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/P4est.jl 92.31% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but just to be sure it would be good if @ranocha had a look as well

@lcw
Copy link
Contributor

lcw commented Mar 27, 2023

I like this! Nice addition @JoshuaLampert.

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice! Thanks, @JoshuaLampert

@ranocha ranocha merged commit e5bb5d3 into trixi-framework:main Mar 27, 2023
@JoshuaLampert JoshuaLampert deleted the default-libsc branch March 27, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants