Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unsafe_wrapping PointerWrappers to vectors #82

Merged
merged 3 commits into from
May 8, 2023

Conversation

JoshuaLampert
Copy link
Member

In Trixi.jl we also need to unsafe_wrap to vectors, not only to matrices.

sloede
sloede previously approved these changes May 8, 2023
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #82 (080057a) into main (d57ae17) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #82   +/-   ##
=======================================
  Coverage   15.90%   15.90%           
=======================================
  Files           3        3           
  Lines        1516     1516           
=======================================
  Hits          241      241           
  Misses       1275     1275           
Flag Coverage Δ
unittests 15.90% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pointerwrappers.jl 95.45% <100.00%> (ø)

sloede
sloede previously approved these changes May 8, 2023
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You could consider to use different names for the wrapped entities in the tests, eg, vertices_matrix and vertices_vector, to avoid ambiguity.

@sloede sloede merged commit 0cbad1b into trixi-framework:main May 8, 2023
@JoshuaLampert JoshuaLampert deleted the unsafe-wrap-vectors branch May 8, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants