Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow any point-wise transformation of the output variables in solution files #174

Closed
sloede opened this issue Sep 8, 2020 · 0 comments · Fixed by #365
Closed

Allow any point-wise transformation of the output variables in solution files #174

sloede opened this issue Sep 8, 2020 · 0 comments · Fixed by #365
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@sloede
Copy link
Member

sloede commented Sep 8, 2020

I think in restart files we should continue to only store the conservative variables, as they are the only guarantee that we will not have any floating point errors due to a restart.

As for the solution files, currently we support "primitive" and "conservative". I think it would be nice to have the option to supply arbitrary transformation functions (that can also be user-supplied), to store, e.g., characteristic variables, entropy variables etc. Since we already have cons2prim, cons2entropy and, with #172, cons2cons, not much additional code would be required, except a mechanism to also supply different variable names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
1 participant