Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend calc_error_norms(func, dg, t) #172

Merged
merged 2 commits into from
Sep 8, 2020

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Sep 8, 2020

No description provided.

@ranocha ranocha requested a review from sloede September 8, 2020 15:11
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & can be merged once the (minor) comments are addressed/discarded.

@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #172 into master will decrease coverage by 2.82%.
The diff coverage is 89.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
- Coverage   94.46%   91.64%   -2.83%     
==========================================
  Files          31       31              
  Lines        6779     6654     -125     
==========================================
- Hits         6404     6098     -306     
- Misses        375      556     +181     
Impacted Files Coverage Δ
src/Trixi.jl 100.00% <ø> (ø)
src/solvers/dg/2d/amr.jl 96.12% <0.00%> (-2.12%) ⬇️
src/equations/3d/hyperbolic_diffusion.jl 82.14% <33.33%> (-3.37%) ⬇️
src/equations/2d/hyperbolic_diffusion.jl 83.96% <36.36%> (-5.35%) ⬇️
src/solvers/dg/interpolation.jl 93.25% <81.81%> (-4.97%) ⬇️
src/equations/2d/ideal_glm_mhd.jl 88.83% <88.23%> (-3.05%) ⬇️
src/equations/3d/ideal_glm_mhd.jl 91.48% <88.23%> (-0.15%) ⬇️
src/equations/3d/compressible_euler.jl 89.38% <89.65%> (+0.03%) ⬆️
src/solvers/dg/2d/dg.jl 93.48% <91.21%> (-3.66%) ⬇️
src/solvers/dg/3d/dg.jl 92.14% <94.53%> (-2.53%) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80a350c...beb5359. Read the comment docs.

@ranocha ranocha merged commit b26e0ea into trixi-framework:master Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants