Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use finalize to print summary callback at end of simulation #2275

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

JoshuaLampert
Copy link
Member

This uses the finalize keyword of the DiscreteCallback to automatically print the output of the SummaryCallback at the end of each simulation. This makes it unnecessary to manually call summary_callback at the end. Since seeing the output twice would be really annoying, this is considered breaking.
Closes #1783.

For potential future reference, I used the following code to automatically remove the `summary_callback` calls in all the elixirs
for (root, _, files) in walkdir("examples")
    for file in files
        if endswith(file, ".jl")
            filename = joinpath(root, file)
            (tmppath, tmpio) = mktemp()
            open(filename) do io
                lines = readlines(io)
                N = length(lines)
                for (i, line) in enumerate(lines)
                    if !contains(line, "summary_callback()") && !contains(line, "# Print the timer summary")
                        # Also remove doubled blank lines if they are there
                        if !(i < N && replace(line, " " => "") == "" && (contains(lines[i + 1], "summary_callback()") || contains(lines[i + 1], "# Print the timer summary")))
                            println(tmpio, line)
                        end
                    end
                end
            end
            close(tmpio)
            mv(tmppath, filename, force = true)
        end
    end
end

Copy link
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.88%. Comparing base (ce47aea) to head (5f12ee4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2275      +/-   ##
==========================================
- Coverage   96.88%   96.88%   -0.00%     
==========================================
  Files         490      490              
  Lines       39491    39492       +1     
==========================================
- Hits        38260    38259       -1     
- Misses       1231     1233       +2     
Flag Coverage Δ
unittests 96.88% <ø> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ranocha ranocha marked this pull request as draft February 11, 2025 15:37
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! I turned this into a draft PR so that nobody accidentally merges it. I needs a final review before being merged, of course.

src/callbacks_step/summary.jl Outdated Show resolved Hide resolved
src/callbacks_step/summary.jl Outdated Show resolved Hide resolved
src/callbacks_step/summary.jl Show resolved Hide resolved
@JoshuaLampert
Copy link
Member Author

The downgrade failure is not really related to this PR, but due to a new version of OrdinaryDiffEqSimplecticRK.jl being released, which leads to a failing downgrade job. If I understand correctly, a way to fix this, is bumping the compat of OrdinaryDiffEq.jl in tests/Project.toml to v6.91.0 (we need this commit, which first appeared in this version). However, fixing this here probably doesn't make so much sense as this PR will probably not be merged soon. I propose to fix this in another PR.

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
@ranocha
Copy link
Member

ranocha commented Feb 13, 2025

Xref SciML/OrdinaryDiffEq.jl#2600 for failing downgrade CI

@JoshuaLampert JoshuaLampert mentioned this pull request Feb 18, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print summary_callback as finalizer
2 participants