-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add documentation for new 1D plotting functionalities #2280
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Auto-merge doesn't work because the required CI runs don't run. So someone with superpower needs to merge this manually. |
The doc build fails since SciML/DiffEqBase.jl#1115 needs to be merged and released. We will wait for it and merge this PR when the Documenter.jl CI job passes. |
Sorry it should come quickly. Long story short, some constructors in SplitFunction referred to that arg as |
Obligatory xkcd reference: Thanks a lot for fixing this 🙏 |
DiffEqBase.jl v6.163.0 is out and fixes the problem. Thanks @ChrisRackauckas! |
This adds some more documentation for the two new features regarding 1D plots implemented in #2250 and #2258 as requested in #2250 (comment).