-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify create_cache
for ControllerThreeLevel*
and the different mesh types
#2285
base: main
Are you sure you want to change the base?
Conversation
…ombined, and the different meshes
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2285 +/- ##
==========================================
- Coverage 96.87% 96.87% -0.00%
==========================================
Files 490 490
Lines 39512 39503 -9
==========================================
- Hits 38275 38266 -9
Misses 1237 1237
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
create_cache
for ControllerThreeLevel*
and the different mesh typescreate_cache
for ControllerThreeLevel*
and the different mesh types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You said, we enable combinations, which were not supported before, such as ControllerThreeLevelCombined
with P4estMesh3D
. Could we add a test for that, e.g., by adding an elixir using this combination?
The function
create_cache
was defined multiple times forControllerThreeLevel
andControllerThreeLevelCombined
, each using different mesh types of varying dimensions. However, all implementations performed the same task. Additionally, some combinations were missing (e.g.,ControllerThreeLevelCombined
withP4estMesh3D
).In this PR, I unify all
create_cache
functions forControllerThreeLevel
andControllerThreeLevelCombined
into a single implementation.