Convert parameter to elixir for 2D Euler tests

[andrewwinters5000]

Addresses more files in #219

[andrewwinters5000]

I am getting the same weird amr error behaviour as @gregorgassner for #230 . The blob + amr test keeps failing for this reason

[ranocha]

Looks good in general, thanks!

I just realized that some Euler examples use split_shockcapturing instead of just shockcapturing (what we use for most other examples). Could you please rename the corresponding .toml and .jl files?

[andrewwinters5000]

I just realized that some Euler examples use split_shockcapturing instead of just shockcapturing (what we use for most other examples). Could you please rename the corresponding .toml and .jl files?

Okay, I can rename such cases. Basically because shock capturing => split form in our current form, but future shock capturing strategies may not use the split form. Should I also add split_shockcapturing to mhd blast wave, Orszag Tang and rotor? Also, all the ec tests use the split volume integral, should this be renamed as well?

Update: I realized looking at the naming that the euler + gravity blast wave should also have split_shockcapturing_amr. So the file name should always have initial conditions + all features used, right? Not to be pedantic but shouldn't all the file names have dg in them because that is the particular solver used? I think this needs input from everyone before I make any changes @gregorgassner @sloede @ranocha

[codecov]

Codecov Report

Merging #229 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #229   +/-   ##
=======================================
  Coverage   89.59%   89.59%           
=======================================
  Files          60       60           
  Lines       10485    10485           
=======================================
  Hits         9394     9394           
  Misses       1091     1091           

Impacted Files	Coverage Δ
src/Trixi.jl	100.00% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc42fd0...a46e23b. Read the comment docs.

[ranocha]

Okay, I can rename such cases. Basically because shock capturing => split form in our current form, but future shock capturing strategies may not use the split form. Should I also add split_shockcapturing to mhd blast wave, Orszag Tang and rotor? Also, all the ec tests use the split volume integral, should this be renamed as well?

For me, just using shockcapturing without split is also okay.

Update: I realized looking at the naming that the euler + gravity blast wave should also have split_shockcapturing_amr. So the file name should always have initial conditions + all features used, right?

For me, just using shockcapturing_amr is fine for MHD, too.

Not to be pedantic but shouldn't all the file names have dg in them because that is the particular solver used? I think this needs input from everyone before I make any changes @gregorgassner @sloede @ranocha

I don't think we need dg now - we don't have something else right now so it's okay to postpone this decision until we have a second solver.

[sloede]

We discussed the naming issue at yesterday's meeting. Our conclusion was that we stick to elixir_equationname_examplename.jl in general. examplename does not have to specify all features that are used, but that it should depend on what the main purpose of this elixir is. If it is an elixir to showcase/validate AMR + shock capturing, elixir_equationname_shockcapturing_amr.jl would be a perfectly suitable name. However, if the main purpose is a specific application that merely happens to use some advanced features, it is not necessary to include them (such as elixir_euler_kelvin_helmholtz_instability.jl or elixir_euler_sedov_blast.jl.

[sloede]

A few minor comments, but the whole looks good to me...

[andrewwinters5000]

Okay, I renamed the files of the elixirs consistently now (I think). @sloede can you double check that I did not miss any? I will update the .toml files too once we settle that all the elixirs are okay...and the tests still pass

[sloede]

Okay, I renamed the files of the elixirs consistently now (I think). @sloede can you double check that I did not miss any? I will update the .toml files too once we settle that all the elixirs are okay...and the tests still pass

I created #244 for this to track the discussion on naming the files. I think optimally we should figure out #244 and then put the changes in here, but if your strapped for time, just finish this PR and we'll figure out #244 next week.

[andrewwinters5000]

I created #244 for this to track the discussion on naming the files. I think optimally we should figure out #244 and then put the changes in here, but if your strapped for time, just finish this PR and we'll figure out #244 next week.

I am strapped for time ;) . So should I not worry about the .toml and just merge this now that the tests have passed?

[sloede]

Yes.