This repository was archived by the owner on Aug 18, 2021. It is now read-only.
Add 3d functionality to Trixi2Img #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now the position of the slice plane is hardcoded.
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
==========================================
+ Coverage 60.23% 66.59% +6.35%
==========================================
Files 5 5
Lines 420 476 +56
==========================================
+ Hits 253 317 +64
+ Misses 167 159 -8
Continue to review full report at Codecov.
|
efaulhaber
commented
Oct 9, 2020
efaulhaber
commented
Oct 9, 2020
efaulhaber
commented
Oct 9, 2020
A lot of variable-independent code was executed again for every variable.
efaulhaber
commented
Oct 9, 2020
sloede
suggested changes
Oct 12, 2020
ranocha
reviewed
Oct 13, 2020
ranocha
reviewed
Oct 13, 2020
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
sloede
suggested changes
Oct 20, 2020
sloede
approved these changes
Oct 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves trixi-framework/Trixi.jl#147.