Add open boundaries

NEWS.md

@@ -17,7 +17,7 @@ We aim at 3 to 4 month between major release versions and about 2 weeks between
 ## Version 0.1.3
 
 ### Added
-Open boundaries using the method of characteristics based on the work of Lastiwka et al., "Permeable and non-reflecting boundary conditions in SPH" (2009) was added for WCSPH and EDAC.
+Open boundaries using the method of characteristics based on the work of Lastiwka et al., "Permeable and non-reflecting boundary conditions in SPH" (2009) were added for WCSPH and EDAC.
 
 ## Version 0.1.2
 

src/general/semidiscretization.jl

@@ -295,7 +295,7 @@ function semidiscretize(semi, tspan; reset_threads=true, data_type=nothing)
             initialize!(system, neighborhood_search)
 
             # Only for systems requiring a mandatory callback
-            initial_callback_flag!(system)
+            reset_callback_flag(system)
         end
     end
 
@@ -360,7 +360,7 @@ function restart_with!(semi, sol; reset_threads=true)
         restart_with!(system, v, u)
 
         # Only for systems requiring a mandatory callback
-        initial_callback_flag!(system)
+        reset_callback_flag(system)
     end
 
     return semi

src/general/system.jl

@@ -121,4 +121,4 @@ function update_final!(system, v, u, v_ode, u_ode, semi, t; update_from_callback
 end
 
 # Only for systems requiring a mandatory callback
-initial_callback_flag!(system) = system
+reset_callback_flag(system) = system

src/schemes/boundary/open_boundary/system.jl

@@ -146,7 +146,7 @@ function Base.show(io::IO, ::MIME"text/plain", system::OpenBoundarySPHSystem)
     end
 end
 
-function initial_callback_flag!(system::OpenBoundarySPHSystem)
+function reset_callback_flag(system::OpenBoundarySPHSystem)
     system.update_callback_used[] = false
 
     return system

test/schemes/boundary/open_boundary/boundary_zone.jl

@@ -6,7 +6,7 @@
         plane_points_1 = [[0.0, 0.0], [0.5, -0.5], [1.0, 0.5]]
         plane_points_2 = [[0.0, 1.0], [0.2, 2.0], [2.3, 0.5]]
 
-        @testset verbose=true "Points $(i)" for i in eachindex(plane_points_1)
+        @testset verbose=true "Points $i" for i in eachindex(plane_points_1)
             point_1 = plane_points_1[i]
             point_2 = plane_points_2[i]
 
@@ -17,7 +17,7 @@
                 -normalize([-plane_size[2], plane_size[1]]),
             ]
 
-            @testset verbose=true "Flow Direction $(j)" for j in eachindex(flow_directions)
+            @testset verbose=true "Flow Direction $j" for j in eachindex(flow_directions)
                 inflow = InFlow(; plane=(point_1, point_2), particle_spacing,
                                 flow_direction=flow_directions[j], density=1.0,
                                 open_boundary_layers)
@@ -64,7 +64,7 @@
             [0.3113730847835541, 0.25057315826416016, -0.02374829351902008],
         ]
 
-        @testset verbose=true "Points $(i)" for i in eachindex(plane_points_1)
+        @testset verbose=true "Points $i" for i in eachindex(plane_points_1)
             point_1 = plane_points_1[i]
             point_2 = plane_points_2[i]
             point_3 = plane_points_3[i]
@@ -77,7 +77,7 @@
                 -normalize(cross(edge1, edge2)),
             ]
 
-            @testset verbose=true "Flow Direction $(j)" for j in eachindex(flow_directions)
+            @testset verbose=true "Flow Direction $j" for j in eachindex(flow_directions)
                 inflow = InFlow(; plane=(point_1, point_2, point_3), particle_spacing,
                                 flow_direction=flow_directions[j], density=1.0,
                                 open_boundary_layers)