Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit reek config from a gem #1430

Open
papa-cool opened this issue Oct 18, 2018 · 1 comment
Open

Inherit reek config from a gem #1430

papa-cool opened this issue Oct 18, 2018 · 1 comment
Assignees
Labels

Comments

@papa-cool
Copy link

In my company, we have several projects that use Code Climate metrics with rubocop, reek...

I'am creating a gem to share an up to date configuration with every projects.
Rubocop has a way to use the config file store into a gem : https://github.com/rubocop-hq/rubocop/blob/master/manual/configuration.md#inheriting-configuration-from-a-dependency-gem

Reek does not seem to have the same possibility. The use of a config file in the home/directory is not enough because it won't be kept up to date and won't work with Code Climate.

What do you think about this feature? Thank you for your help.

@troessner
Copy link
Owner

troessner commented Oct 18, 2018

The bad news:

Unfortunately, this is not possible at the moment. Neither does Reek offer the option to use more than one configuration file nor does it allow you to specify a configuration file inside a gem.

The good news:

We are working on it! ;)
See #1411 if you're interested in the details. In short we'll:

2.) Add the feature to Reek that allows to include additional configuration files via include directive and reverse-merge whatever it finds in those files.

This is certainly one of the next features that we are going to tackle (we started to work on this in #1426 already).

This

Rubocop has a way to use the config file store into a gem : https://github.com/rubocop-hq/rubocop/blob/master/manual/configuration.md#inheriting-configuration-from-a-dependency-gem

certainly sounds like a nice follow-up. I have no ETA for both features though, so it might make sense for you to subscribe to the mentioned issue and pull request above.

@troessner troessner self-assigned this Oct 18, 2018
papa-cool added a commit to jobteaser/shared-config-files that referenced this issue Oct 19, 2018
Rubocop has an inheritance system to share rubocop config with a gem.
See: https://blog.percy.io/share-rubocop-rules-across-all-of-your-repos-f3281fbd71f8

Reek does not have identical system. We are waiting for: troessner/reek#1430

Code Climate can use config from a gem: https://codeclimate.com/changelog/582495c32c33066f1b00191d/
papa-cool added a commit to jobteaser/shared-config-files that referenced this issue Oct 19, 2018
Rubocop has an inheritance system to share rubocop config with a gem.
See: https://blog.percy.io/share-rubocop-rules-across-all-of-your-repos-f3281fbd71f8

Reek does not have identical system. We are waiting for: troessner/reek#1430

Code Climate can use config from a gem: https://codeclimate.com/changelog/582495c32c33066f1b00191d/
papa-cool added a commit to jobteaser/shared-config-files that referenced this issue Oct 19, 2018
Rubocop has an inheritance system to share rubocop config with a gem.
See: https://blog.percy.io/share-rubocop-rules-across-all-of-your-repos-f3281fbd71f8

Reek does not have identical system. We are waiting for: troessner/reek#1430

Code Climate can use config from a gem: https://codeclimate.com/changelog/582495c32c33066f1b00191d/
papa-cool added a commit to jobteaser/shared-config-files that referenced this issue Nov 22, 2018
Rubocop has an inheritance system to share rubocop config with a gem.
See: https://blog.percy.io/share-rubocop-rules-across-all-of-your-repos-f3281fbd71f8

Reek does not have identical system. We are waiting for: troessner/reek#1430

Code Climate can use config from a gem: https://codeclimate.com/changelog/582495c32c33066f1b00191d/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants