Simplify SmellWarning class #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvz
force-pushed
the
simplify-smell-warning
branch
from
4044401 to
b02f2b7
Compare
troessner
requested changes
Aug 25, 2019
|
|
||
| # @note When using Reek's public API, you should not create SmellWarning | ||
| # objects yourself. This is why the initializer is not part of the | ||
| # public API. | ||
| # | ||
| # @quality :reek:LongParameterList { max_params: 6 } | ||
| def initialize(smell_detector, context: '', lines:, message:, | ||
| def initialize(smell_type, context: '', lines:, message:, |
There was a problem hiding this comment.
Let's use this opportunity to add proper parameter documentation :)
troessner
approved these changes
Aug 26, 2019
|
Hm. Can we not squash merge? I really hate it. |
|
You mean not squash anymore at all or are you referring to this specific case? If it's the latter, how about leaving a comment for the reviewer (or label it) that we shouldnt squash on merge? |
|
I mean in general not use GitHub's squash merge option. |
|
A short list of why I don't like it:
|
|
Ok, no worries, I'm ok with not using it anymore :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SmellWarning#initialize