Make UtilityFunction configurable for non-public methods. #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troessner
force-pushed
the
make-utility-function-configurable-for-non-public-methods
branch
from
5554332 to
6e107a4
Compare
| @@ -53,11 +56,13 @@ def contexts # :nodoc: | |||
| # @return [Array<SmellWarning>] | |||
| # | |||
| # :reek:FeatureEnvy | |||
| # :reek:TooManyStatements: { max_statements: 6 } | |||
There was a problem hiding this comment.
Kind of sucks, but refactoring UtilityFunction is out of the scope for this PR and I'd rather address this separately.
There was a problem hiding this comment.
Addendum: After thinking about it I came to the conclusion that the number of statements is not a smell here but indeed justified.
I'd leave it exactly the way it is since it is super readable.
troessner
force-pushed
the
make-utility-function-configurable-for-non-public-methods
branch
from
6e107a4 to
9dd4736
Compare
mvz
added a commit
that referenced
this pull request
Sep 16, 2015
…able-for-non-public-methods Make UtilityFunction configurable for non-public methods.
mvz
deleted the
make-utility-function-configurable-for-non-public-methods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #681
CC'ing @isaiah @nTraum @lipanski @hwo411 @RaVbaker @tomash
After this is merged we should release 3.4. as well.