Hide secret information #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
|
Thank you for your contribution to editline! :-) The PR cannot be merged directly due to conflicts. There is also a lot of whitespace changes mixed in with the new functionality. Would you mind redoing the PR; fix the conflicts and also split out (or remove) the whitespace as a separate commit? |
|
ok sure ! Thank you ! |
|
No, thank you! :) |
|
just for the info: this PR to add new feature in |
cogutvalera
force-pushed
the
issue_1171
branch
from
e519028 to
3cd9894
Compare
|
I've pushed |
rofl0r
reviewed
Oct 18, 2018
src/editline.c
Outdated
| if (rl_check_secret(rl_line_buffer)) | ||
| res = write(el_outfd, "", 1); | ||
| else | ||
| res = write(el_outfd, Screen, ScreenCount); |
There was a problem hiding this comment.
inconsistent indentation...
cogutvalera
force-pushed
the
issue_1171
branch
from
ac96d67 to
1db83fe
Compare
|
Thanks ! |
|
No problem. I didn't understand the use-case at first, and I assumed you'd already seen the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to hide secret information