Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Systemd service type 'notify' #155

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

bombadil
Copy link
Collaborator

@bombadil bombadil commented Mar 1, 2021

By calling sd_notify() the smcroute daemon (smcrouted) can tell the systemd
service manager when it is fully up and running. This allows systemd to manage
services synchronously (i.e. use service type 'notify') so that dependent tasks
can rely on smcrouted being fully up and running.

This patch is already in use in Debian package smcroute/2.4.4-2.

Related Debian bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=924361

By calling sd_notify() the smcroute daemon (smcrouted) can tell the systemd
service manager when it is fully up and running. This allows systemd to manage
services synchronously (i.e. use service type 'notify') so that dependent tasks
can rely on smcrouted being fully up and running.

This patch is already in use in Debian package smcroute/2.4.4-2.

Related Debian bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=924361
@troglobit
Copy link
Owner

Awesome, this is exactly what I considered when I first saw that Debian bug. Thank you for taking the time to submit this change! <3

@troglobit troglobit merged commit 1b62606 into dev Mar 2, 2021
@troglobit troglobit deleted the systemd_notify_support branch March 2, 2021 22:55
troglobit added a commit that referenced this pull request Aug 22, 2021
 - Restore lost NotifyAccess=main from PR #155
 - Minor whitespace fixes for readability and consistency

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants