Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/internal tx switch #1811

Merged
merged 2 commits into from
Dec 3, 2018
Merged

Feat/internal tx switch #1811

merged 2 commits into from
Dec 3, 2018

Conversation

ithinker1991
Copy link
Contributor

What does this PR do?
Feat/internal tx switch

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@ithinker1991 ithinker1991 requested a review from taihaofu December 3, 2018 12:14
@codecov-io
Copy link

Codecov Report

Merging #1811 into Odyssey_v3.2.2 will increase coverage by 0.17%.
The diff coverage is 40%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             Odyssey_v3.2.2    #1811      +/-   ##
====================================================
+ Coverage             45.15%   45.33%   +0.17%     
- Complexity             3761     3787      +26     
====================================================
  Files                   452      452              
  Lines                 27016    27020       +4     
  Branches               2740     2741       +1     
====================================================
+ Hits                  12200    12250      +50     
+ Misses                13763    13705      -58     
- Partials               1053     1065      +12
Impacted Files Coverage Δ Complexity Δ
.../org/tron/core/capsule/TransactionInfoCapsule.java 48.69% <0%> (-13.05%) 16 <0> (-1)
src/main/java/org/tron/core/config/args/Args.java 62.07% <50%> (-0.09%) 125 <1> (+2)
...common/runtime/vm/program/InternalTransaction.java 76.92% <0%> (-0.97%) 13% <0%> (-1%)
src/main/java/org/tron/core/db/Manager.java 49.01% <0%> (+0.12%) 111% <0%> (+1%) ⬆️
src/main/java/org/tron/core/db/KhaosDatabase.java 63.69% <0%> (+0.63%) 25% <0%> (+1%) ⬆️
.../java/org/tron/core/net/node/NodeDelegateImpl.java 34% <0%> (+0.66%) 19% <0%> (+1%) ⬆️
...a/org/tron/common/overlay/server/MessageQueue.java 82.6% <0%> (+1.08%) 32% <0%> (+1%) ⬆️
src/main/java/org/tron/core/net/node/NodeImpl.java 48.12% <0%> (+2.06%) 85% <0%> (+5%) ⬆️
...ay/discover/node/statistics/MessageStatistics.java 67.58% <0%> (+2.75%) 21% <0%> (+2%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dcf0c0...e48f2ab. Read the comment docs.

@taihaofu taihaofu merged commit f063ee4 into Odyssey_v3.2.2 Dec 3, 2018
@shydesky shydesky deleted the feat/internal_tx_switch branch November 13, 2019 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants