Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/limit http body size #2006

Merged
merged 2 commits into from
Feb 25, 2019
Merged

Conversation

renchenchang
Copy link
Contributor

What does this PR do?
limit the body size in http interfaces to avoid DOS attack

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

Copy link
Contributor

@zergweak zergweak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@codecov-io
Copy link

Codecov Report

Merging #2006 into develop will decrease coverage by 0.12%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2006      +/-   ##
=============================================
- Coverage      44.91%   44.78%   -0.13%     
+ Complexity      4035     4034       -1     
=============================================
  Files            489      489              
  Lines          28764    28833      +69     
  Branches        3006     3007       +1     
=============================================
- Hits           12919    12913       -6     
- Misses         14694    14768      +74     
- Partials        1151     1152       +1
Impacted Files Coverage Δ Complexity Δ
.../tron/core/services/http/GetBlockByNumServlet.java 6.25% <0%> (-0.21%) 2 <0> (ø)
...tron/core/services/http/ProposalCreateServlet.java 10% <0%> (-0.53%) 2 <0> (ø)
.../http/solidity/GetTransactionsFromThisServlet.java 8.33% <0%> (-0.37%) 2 <0> (ø)
...ore/services/http/GetDelegatedResourceServlet.java 5.4% <0%> (-0.16%) 2 <0> (ø)
...on/core/services/http/ExchangeWithdrawServlet.java 10.52% <0%> (-0.59%) 2 <0> (ø)
.../tron/core/services/http/UpdateSettingServlet.java 10% <0%> (-0.53%) 2 <0> (ø)
...olidity/GetTransactionInfoByIdSolidityServlet.java 6.06% <0%> (-0.19%) 2 <0> (ø)
...tron/core/services/http/ExchangeInjectServlet.java 10.52% <0%> (-0.59%) 2 <0> (ø)
...ron/core/services/http/GetExchangeByIdServlet.java 6.66% <0%> (-0.23%) 2 <0> (ø)
...core/services/http/GetBlockByLatestNumServlet.java 5.4% <0%> (-0.16%) 2 <0> (ø)
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baf57d2...f79165c. Read the comment docs.

@shiziwen
Copy link

ok

@renchenchang renchenchang merged commit 09f0c6d into develop Feb 25, 2019
@shydesky shydesky deleted the hotfix/limit-http-body-size branch November 13, 2019 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants