Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added info under Prepared dependencies section, to suggest Linux Ubuntu's users, using Oracle JDK 8, instead of OpenJDK 8, to avoid error build #339

Merged
merged 1 commit into from
Apr 2, 2018

Conversation

WendySanarwanto
Copy link
Contributor

What does this PR do?
Changed README.md file by adding info under Prepared dependencies section, to suggest Linux Ubuntu's users, using Oracle JDK 8, instead of OpenJDK 8, to avoid error build.

Why are these changes required?
Some Linux Ubuntu users are using OpenJDK 8 instead of using Oracle JDK 8. Before this PR, the Prepared dependencies section only mention JDK , not mentioning specific JDK flavor. Also, building the source code using OpenJDK 8 will result in BUILD FAILED outcome (see: #337). By adding more info in Prepared dependencies section, we could help Linux Ubuntu user (whom use OpenJDK 8), avoiding this build error.

This PR has been tested by:

  • Manual Testing

Follow up

Extra details
Machine environment:

  • Ubuntu OS version 16.04.4 LTS.
  • Oracle JDK 8

…ers, using Oracle JDK 8, instead of OpenJDK 8, to avoid error build.
Copy link
Contributor

@sasaxie sasaxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaohong zhaohong merged commit d942baf into tronprotocol:develop Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants