Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stake2.0): optimize code, remove useless code #4997

Merged
merged 1 commit into from
Feb 16, 2023
Merged

feat(stake2.0): optimize code, remove useless code #4997

merged 1 commit into from
Feb 16, 2023

Conversation

CarlChaoCarl
Copy link
Contributor

@CarlChaoCarl CarlChaoCarl commented Feb 15, 2023

What does this PR do?
remove useless code in Stake 2.0

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@CarlChaoCarl CarlChaoCarl changed the base branch from develop to release_v4.7.1 February 15, 2023 10:58
@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2023

Codecov Report

Merging #4997 (15b36cc) into release_v4.7.1 (50ad05a) will increase coverage by 0.03%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@                 Coverage Diff                  @@
##             release_v4.7.1    #4997      +/-   ##
====================================================
+ Coverage             54.70%   54.74%   +0.03%     
- Complexity             8220     8226       +6     
====================================================
  Files                   841      841              
  Lines                 49702    49697       -5     
  Branches               5456     5456              
====================================================
+ Hits                  27191    27205      +14     
+ Misses                20369    20350      -19     
  Partials               2142     2142              
Impacted Files Coverage Δ
...ices/http/solidity/SolidityNodeHttpApiService.java 4.16% <ø> (+0.27%) ⬆️
.../java/org/tron/core/consensus/BlockHandleImpl.java 65.00% <0.00%> (-15.00%) ⬇️
...rc/main/java/org/tron/consensus/dpos/DposTask.java 87.09% <0.00%> (-3.23%) ⬇️
framework/src/main/java/org/tron/core/Wallet.java 37.32% <0.00%> (-0.04%) ⬇️
...java/org/tron/core/capsule/TransactionCapsule.java 52.68% <0.00%> (+0.23%) ⬆️
...ork/src/main/java/org/tron/core/trie/TrieImpl.java 58.24% <0.00%> (+0.35%) ⬆️
...mework/src/main/java/org/tron/core/db/Manager.java 53.76% <0.00%> (+0.67%) ⬆️
...g/tron/core/capsule/utils/FastByteComparisons.java 68.00% <0.00%> (+4.00%) ⬆️
...src/main/java/org/tron/core/db/PendingManager.java 51.16% <0.00%> (+16.27%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zhang0125 zhang0125 merged commit f1f9353 into tronprotocol:release_v4.7.1 Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants