Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(net): modify getting blockid preference #5283

Merged

Conversation

317787106
Copy link
Contributor

@317787106 317787106 commented Jun 19, 2023

What does this PR do?

  • if num is bigger than head num, get blockid from khaosdb when generating syncblockchain message

Why are these changes required?

  • if num is bigger than dynamic store's head, getting block from index store will fail

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2023

Codecov Report

Merging #5283 (cb3df71) into release_v4.7.2 (de45672) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@                 Coverage Diff                  @@
##             release_v4.7.2    #5283      +/-   ##
====================================================
- Coverage             60.86%   60.86%   -0.01%     
- Complexity             9197     9199       +2     
====================================================
  Files                   839      839              
  Lines                 49937    49940       +3     
  Branches               5562     5563       +1     
====================================================
  Hits                  30396    30396              
- Misses                17158    17162       +4     
+ Partials               2383     2382       -1     
Impacted Files Coverage Δ
...va/org/tron/core/net/service/sync/SyncService.java 57.78% <50.00%> (-0.89%) ⬇️

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@317787106 317787106 requested a review from xxo1shine June 19, 2023 10:41
@317787106 317787106 changed the title fix(net):if num is bigger than head num, get blockid from khaosdb fix(net):prefer to get blockId from khaosdb in SyncService Jun 19, 2023
@317787106 317787106 merged commit 76cf24f into tronprotocol:release_v4.7.2 Jun 19, 2023
@317787106 317787106 changed the title fix(net):prefer to get blockId from khaosdb in SyncService fix(net): modify getting blockid preference Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants