Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync main to r1.0 #36

Merged
merged 11 commits into from
Dec 11, 2024
Merged

sync main to r1.0 #36

merged 11 commits into from
Dec 11, 2024

Conversation

liuzengh
Copy link
Contributor

No description provided.

liuzengh and others added 10 commits December 13, 2023 15:55
* kafka: update sarama dependence

* fix unit test
* feat: add localcache plugin

* chore: update LICENSE

* test: add localcache workflow

* chore: yaml version

* test: flaky test
* add mongodb

* revert cover.out

* update LICENSE and fix variable name

* update comments
sync from the internal merge request 1442
…rategies instead of deprecated Strategy config (#34)

sync from the internal merge request 1442
@liuzengh liuzengh requested a review from a team as a code owner December 11, 2024 07:07
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


3 out of 4 committers have signed the CLA.
✅ (liuzengh)[https://github.com/liuzengh]
✅ (Flash-LHR)[https://github.com/Flash-LHR]
✅ (YoungFr)[https://github.com/YoungFr]
@Leoyoungxh
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 83.63636% with 9 lines in your changes missing coverage. Please review.

Project coverage is 90.08%. Comparing base (1898adc) to head (27d1450).

Files with missing lines Patch % Lines
kafka/config_parser.go 78.57% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             r1.0      #36       +/-   ##
===========================================
+ Coverage   79.25%   90.08%   +10.82%     
===========================================
  Files          77       10       -67     
  Lines        7782     1240     -6542     
===========================================
- Hits         6168     1117     -5051     
+ Misses       1387       92     -1295     
+ Partials      227       31      -196     
Flag Coverage Δ
bigcache ?
clickhouse ?
cos ?
goes ?
goredis ?
gorm ?
hbase ?
kafka 90.08% <83.63%> (-0.34%) ⬇️
localcache ?
mongodb ?
mysql ?
timer ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liuzengh liuzengh merged commit 6e5ff98 into r1.0 Dec 11, 2024
4 of 5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants