Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Fix the issue that the user fails to read data in the scenario where an HTTP chunked client encounters a disconnection immediately after completing data reception #100

Merged

Conversation

bochencwx
Copy link
Contributor

No description provided.

…o where an HTTP chunked client encounters a disconnection immediately after completing data reception
@bochencwx bochencwx force-pushed the bugfix/http_client_stream_read branch from e4ff714 to 80b969c Compare January 3, 2024 10:04
@bochencwx bochencwx changed the title BugFix: Fix the issue that the user fails to read data in the scenario where an HTTP chunked client encounters a disconnection immediately after completing data reception (#99) BugFix: Fix the issue that the user fails to read data in the scenario where an HTTP chunked client encounters a disconnection immediately after completing data reception Jan 3, 2024
@bochencwx
Copy link
Contributor Author

close #99

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4147869) 81.76052% compared to head (80b969c) 81.70742%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #100         +/-   ##
===================================================
- Coverage   81.76052%   81.70742%   -0.05311%     
===================================================
  Files            855         855                 
  Lines          33899       33899                 
===================================================
- Hits           27716       27698         -18     
- Misses          6183        6201         +18     
Files Coverage Δ
trpc/stream/http/http_client_stream.h 97.67442% <100.00000%> (+2.32558%) ⬆️

... and 6 files with indirect coverage changes

@helloopenworld helloopenworld merged commit 4a8c37a into trpc-group:main Jan 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants