Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature:redis reply change from union to variant #115

Merged

Conversation

yujun411522
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (fe2471a) 81.83292% compared to head (89cdf2e) 81.65536%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #115         +/-   ##
===================================================
- Coverage   81.83292%   81.65536%   -0.17756%     
===================================================
  Files            855         855                 
  Lines          33924       33890         -34     
===================================================
- Hits           27761       27673         -88     
- Misses          6163        6217         +54     
Files Coverage Δ
trpc/client/redis/reader.cc 96.57143% <100.00000%> (-0.49602%) ⬇️
trpc/client/redis/reply.h 41.41414% <27.27273%> (-28.87573%) ⬇️

... and 15 files with indirect coverage changes

Copy link
Contributor

@helloopenworld helloopenworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@helloopenworld helloopenworld merged commit 7eff8ba into trpc-group:main Feb 20, 2024
3 checks passed
@yujun411522 yujun411522 deleted the feature/redis_reply_union2variant branch May 6, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants