Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Modify the key of scheduling_map to std::string to avoid accessing SeparateScheduling as nullptr during startup #118

Merged

Conversation

yujun411522
Copy link
Contributor

…essing SeparateScheduling as nullptr during startup

…essing SeparateScheduling as nullptr during startup
@yujun411522 yujun411522 changed the title Feature: Modify the key of scheduling_map to std::string to avoid acc… Feature: Modify the key of scheduling_map to std::string to avoid accessing SeparateScheduling as nullptr during startup Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.65000%. Comparing base (ce53eec) to head (7845ac4).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #118         +/-   ##
===================================================
- Coverage   81.75622%   81.65000%   -0.10622%     
===================================================
  Files            855         855                 
  Lines          33891       33891                 
===================================================
- Hits           27708       27672         -36     
- Misses          6183        6219         +36     
Files Coverage Δ
...untime/threadmodel/separate/separate_scheduling.cc 100.00000% <100.00000%> (ø)
...runtime/threadmodel/separate/separate_scheduling.h 33.33333% <ø> (ø)

... and 10 files with indirect coverage changes

@helloopenworld helloopenworld merged commit f0a78df into trpc-group:main Mar 8, 2024
4 checks passed
@yujun411522 yujun411522 deleted the feature/scheduling_map_string branch May 6, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants