Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support using trpc protocol at remote side #124

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

weimch
Copy link
Contributor

@weimch weimch commented Mar 21, 2024

  • import remote side trpc.proto at "trpc/trpc.proto" file.
  • use remote side trpc_options.proto instead local one.
  • intergate remote trpc protocol repo with bazel and cmake compiling progress.

- import remote side trpc.proto at "trpc/trpc.proto" file.
- use remote side trpc_options.proto instead local one.
- intergate remote trpc protocol repo with bazel and cmake compiling progress.
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.64704%. Comparing base (53be380) to head (ef6f752).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #124         +/-   ##
===================================================
- Coverage   81.66180%   81.64704%   -0.01476%     
===================================================
  Files            855         855                 
  Lines          33891       33891                 
===================================================
- Hits           27676       27671          -5     
- Misses          6215        6220          +5     

see 5 files with indirect coverage changes

Copy link
Contributor

@helloopenworld helloopenworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

@helloopenworld helloopenworld merged commit 00af5f2 into trpc-group:main Mar 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants