BugFix: fix coredump of trpc::config::GetInt64() with overflowed int32 #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue: trpc::config::GetInt64() with json may coredump when real value is greater than INT32_MAX. cause: asInt() of json-cpp with overflowed interge will assert failure. fix: change asInt() to asInt64().
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
liuzengh
added a commit
to trpc-group/cla-database
that referenced
this pull request
Dec 8, 2023
|
close #88 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
===================================================
- Coverage 81.79932% 81.74070% -0.05862%
===================================================
Files 855 855
Lines 33746 33791 +45
===================================================
+ Hits 27604 27621 +17
- Misses 6142 6170 +28
|
helloopenworld
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: trpc::config::GetInt64() with json may coredump when real value is greater than INT32_MAX.
cause: asInt() of json-cpp with overflowed interge will assert failure.
fix: change asInt() to asInt64().