Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: static props inference #62

Closed
wants to merge 4 commits into from
Closed

fix: static props inference #62

wants to merge 4 commits into from

Conversation

bautistaaa
Copy link

@bautistaaa bautistaaa commented Jun 15, 2022

Description

Example was not inferring static props and resulting in never

Found this gem buried in an issue and applied the same solution here
vercel/next.js#15913 (comment)

image

@vercel
Copy link

vercel bot commented Jun 15, 2022

@bautistaaa is attempting to deploy a commit to the trpc Team on Vercel.

A member of the Team first needs to authorize it.

@bautistaaa
Copy link
Author

cc @KATT

@vercel
Copy link

vercel bot commented Jun 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
kitchen-sink ✅ Ready (Inspect) Visit Preview Jun 19, 2022 at 11:52PM (UTC)

KATT
KATT previously approved these changes Jun 19, 2022
@KATT
Copy link
Member

KATT commented Jun 19, 2022

@bautistaaa seems to have some prettier issues :)

@KATT KATT disabled auto-merge June 19, 2022 22:50
@KATT KATT dismissed their stale review June 19, 2022 22:51

stale

@KATT
Copy link
Member

KATT commented Jun 19, 2022

also, if the example is using a helper, it should probably be included in the paths that are displayed on the page

@KATT
Copy link
Member

KATT commented Jun 19, 2022

See https://github.com/trpc/examples-kitchen-sink/blob/main/src/feature/ssg/meta.tsx

@bautistaaa
Copy link
Author

bautistaaa commented Jun 19, 2022

See https://github.com/trpc/examples-kitchen-sink/blob/main/src/feature/ssg/meta.tsx

Was this what you had in mind? Added a SS to the PR description as well

1f21578

@bautistaaa bautistaaa requested a review from KATT June 19, 2022 23:42
@bautistaaa
Copy link
Author

@KATT looks like e2e is stuck 😬

@bautistaaa bautistaaa closed this Oct 3, 2022
auto-merge was automatically disabled October 3, 2022 19:44

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants