Skip to content

Commit

Permalink
Update to include better create warning logs and remove update context (
Browse files Browse the repository at this point in the history
Azure#20)

* Update to include better create warning logs and remove update context

* Remove help text for update

* Fix spelling error

* Update message
  • Loading branch information
jonathan-innis authored Apr 2, 2021
1 parent 3290f6e commit 22c8e92
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 9 deletions.
6 changes: 6 additions & 0 deletions src/k8s-extension/HISTORY.rst
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@
Release History
===============

0.2.1
++++++++++++++++++

* Remove `k8s-extension update` until PATCH is supported
* Improved logging for overwriting extension name with default

0.2.0
++++++++++++++++++

Expand Down
2 changes: 1 addition & 1 deletion src/k8s-extension/azext_k8s_extension/_consts.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@
# --------------------------------------------------------------------------------------------

EXTENSION_NAME = 'k8s-extension'
VERSION = "0.2.0"
VERSION = "0.2.1"
5 changes: 0 additions & 5 deletions src/k8s-extension/azext_k8s_extension/_help.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,3 @@
type: command
short-summary: Show details of a K8s-extension.
"""

helps[f'{consts.EXTENSION_NAME} update'] = """
type: command
short-summary: Update a K8s-extension.
"""
1 change: 0 additions & 1 deletion src/k8s-extension/azext_k8s_extension/commands.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ def load_command_table(self, _):
is_preview=True) \
as g:
g.custom_command('create', 'create_k8s_extension')
g.custom_command('update', 'update_k8s_extension')
g.custom_command('delete', 'delete_k8s_extension', confirmation=True)
g.custom_command('list', 'list_k8s_extension', table_transformer=k8s_extension_list_table_format)
g.custom_show_command('show', 'show_k8s_extension', table_transformer=k8s_extension_show_table_format)
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ def Create(self, cmd, client, resource_group_name, cluster_name, name, cluster_t
is_ci_extension_type = False

logger.warning('Ignoring name, release-namespace and scope parameters since %s '
'only supports cluster scope and single instance of this extension', extension_type)
'only supports cluster scope and single instance of this extension.', extension_type)
logger.warning("Defaulting to extension name '%s' and release-namespace '%s'", name, release_namespace)

_get_container_insights_settings(cmd, resource_group_name, cluster_name, configuration_settings,
configuration_protected_settings, is_ci_extension_type)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ def Create(self, cmd, client, resource_group_name, cluster_name, name, cluster_t
is_ci_extension_type = True

logger.warning('Ignoring name, release-namespace and scope parameters since %s '
'only supports cluster scope and single instance of this extension', extension_type)
'only supports cluster scope and single instance of this extension.', extension_type)
logger.warning("Defaulting to extension name '%s' and release-namespace '%s'", name, release_namespace)

_get_container_insights_settings(cmd, resource_group_name, cluster_name, configuration_settings,
configuration_protected_settings, is_ci_extension_type)
Expand Down

0 comments on commit 22c8e92

Please sign in to comment.