Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextcloud): set default phone region #3578

Merged
merged 2 commits into from
Aug 26, 2022

Conversation

stavros-k
Copy link
Collaborator

@stavros-k stavros-k commented Aug 26, 2022

Description

⚒️ Fixes #3577

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

📃 Notes:

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • 🪞 I have opened a PR on truecharts/containers adding the container to TrueCharts mirror repo.
  • 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

@truecharts-admin truecharts-admin added size/S Categorises a PR that changes 10-29 lines, ignoring generated files. precommit:ok CI status: pre-commit validation successful lint:ok CI status: linting successful install:ok CI status: install successful labels Aug 26, 2022
@PrivatePuffin
Copy link
Member

Wontfix, in favor of:
nextcloud/docker#1795

I'm going to put a stop on all these occ things dunked in the hpb container, I was working on moving them out and this is extremely complicating my job.

@PrivatePuffin
Copy link
Member

@stavros-k try adding NC_default_phone_region instead.

@PrivatePuffin
Copy link
Member

Actually, I am going to implement this. Sorry. Brb

@PrivatePuffin PrivatePuffin reopened this Aug 26, 2022
@PrivatePuffin PrivatePuffin merged commit 6c5aa11 into truecharts:master Aug 26, 2022
@stavros-k stavros-k deleted the ncphone branch August 26, 2022 13:21
@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators Apr 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
install:ok CI status: install successful lint:ok CI status: linting successful precommit:ok CI status: pre-commit validation successful size/S Categorises a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nextcloud default_phone_region Environment Variable
3 participants