Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] default REGEX_DOMAIN incorrectly limits top level domain to 7 characters max #8

Closed
AlexeyDemidov opened this issue Mar 25, 2019 · 1 comment
Closed

[BUG] default REGEX_DOMAIN incorrectly limits top level domain to 7 characters max #8

AlexeyDemidov opened this issue Mar 25, 2019 · 1 comment
Assignees
@bestwebua
Labels
bug Something isn't working

Comments

@AlexeyDemidov
Copy link

default REGEX_DOMAIN restricts top level domain part to only 7 characters, which will incorrectly reject as invalid 512 out of 1532 currently existing TLDs as the longest one is 24 characters long. Please see http://data.iana.org/TLD/tlds-alpha-by-domain.txt for the full list of currently exiting TLD. Proper limit should be 63 characters.
@bestwebua bestwebua self-assigned this Mar 27, 2019
@bestwebua bestwebua added the bug Something isn't working label Mar 27, 2019
bestwebua added a commit that referenced this issue Mar 27, 2019
@bestwebua
Fix regex issues: #7, #8, #9
0b7e5d7
@bestwebua bestwebua mentioned this issue Mar 27, 2019
Merged
5 tasks
bestwebua added a commit that referenced this issue Mar 27, 2019
@bestwebua
Fix regex issues: #7, #8, #9 (#20)
01f9de3 
* Fix regex issues: #7, #8, #9
* Update tests
@bestwebua
Copy link
Member

👍 Fixed!

@bestwebua bestwebua changed the title default REGEX_DOMAIN incorrectly limits top level domain to 7 characters max [BUG] default REGEX_DOMAIN incorrectly limits top level domain to 7 characters max Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bestwebua bestwebua

Labels
bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlexeyDemidov @bestwebua