Fix mx issues: #10, #11, #12, #13, #17 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexxty7
reviewed
Apr 1, 2019
Complete MX validator tests Update reek config Refactor namespaces Refactor Refactor Update gem documentation Add new features Add .valid? tests Refactor Implement Configuration#retry_count Update linter config Implement ResolverExecutionWrapper Update documentation Update gem version Update documentation Refactor ResolverExecutionWrapper
bestwebua
force-pushed
the
bugfix/mx-issues
branch
from
29a5b8d
to
ade2a24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed MX gem logic with RFC 5321: https://tools.ietf.org/html/rfc5321#section-5
MXandCNAMErecords not exist, [BUG] MX checks don't check for presence of A record if MX records are missing #10CNAMErecords, [BUG] MX checks can't handle CNAME records #11MXandCNAMErecords not found, [BUG] MX checks don't check if results are resolvable into A or AAAA records #12.valid?helper