NAS-130178 / 24.10 / Disable IPv6 link_local addresses in Send Targets output #14059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
1 similar comment
anodos325
approved these changes
Jul 23, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When link-local addresses are included in Send Targets response, it can cause breakage at the initiator, depending on whether or not it handles the zone-index and/or whether the client interface names happen to line up with the TrueNAS system. This is currently broken in
open-iscsi.Since link-local addresses are non-routable, the safest approach is to not include them in the Send Targets output. [If no non-link-local addresses are present then querying the link-local IPv6 will still include that address (only).]
(See upstream
scstPR #228 for more info)CI run with passing iSCSI tests is here.