Skip to content

Commit

Permalink
ZTS: Test for all known zpool feature sets
Browse files Browse the repository at this point in the history
zpool_create_features_007_pos only tested for compat-2020 feature
set. It would be useful to test for all known features sets. If
any additional feature is found enabled that is not present in
compatibility list or feature set, it should be caught and
reported earlier.

This commit also removes encryption from openzfsonosx-1.8.1
compatibility list. Encryption enables bookmark_v2, since it is
a dependency of encryption, but not listed in openzfsonoxx-1.8.1
compatibility list.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#15505
  • Loading branch information
usaleem-ix authored and tonyhutter committed Nov 16, 2023
1 parent f863ac3 commit f1659cc
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
1 change: 0 additions & 1 deletion cmd/zpool/compatibility.d/openzfsonosx-1.8.1
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ edonr
embedded_data
empty_bpobj
enabled_txg
encryption
extensible_dataset
filesystem_limits
hole_birth
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
# STRATEGY:
# 1. Create a pool with a known feature set.
# 2. Verify only those features are active/enabled.
# 3. Do this for all known feature sets
#

verify_runnable "global"
Expand All @@ -47,8 +48,11 @@ log_onexit cleanup

log_assert "creates a pool with a specified feature set enabled"

log_must zpool create -f -o compatibility=compat-2020 $TESTPOOL $DISKS
check_feature_set $TESTPOOL compat-2020
log_must zpool destroy -f $TESTPOOL
for compat in "$ZPOOL_COMPAT_DIR"/*
do
log_must zpool create -f -o compatibility="${compat##*/}" $TESTPOOL $DISKS
check_feature_set $TESTPOOL "${compat##*/}"
log_must zpool destroy -f $TESTPOOL
done

log_pass "creates a pool with a specified feature set enabled"

0 comments on commit f1659cc

Please sign in to comment.